test: flaky test-stdout-close-catch on freebsd#32849
Closed
sam-github wants to merge 2 commits intonodejs:masterfrom
Closed
test: flaky test-stdout-close-catch on freebsd#32849sam-github wants to merge 2 commits intonodejs:masterfrom
sam-github wants to merge 2 commits intonodejs:masterfrom
Conversation
Collaborator
richardlau
approved these changes
Apr 14, 2020
sam-github
added
the
fast-track
Contributor
Author
|
can I fast track? |
lpinca
approved these changes
Apr 14, 2020
jasnell
approved these changes
Apr 15, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: nodejs#31280
sam-github
force-pushed
the
flaky-test-stdout-close-catch
branch
from
5b413a5 to
a4c4087
Compare
BridgeAR
approved these changes
Apr 17, 2020
addaleax
approved these changes
Apr 27, 2020
addaleax
added
author ready
Collaborator
addaleax
pushed a commit
that referenced
this pull request
Apr 28, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Apr 28, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: #31280 PR-URL: #32849 Refs: #28803 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed in 1d0b249...8e956f4 |
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: #31280 PR-URL: #32849 Refs: #28803 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 7, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: #31280 PR-URL: #32849 Refs: #28803 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: #31280 PR-URL: #32849 Refs: #28803 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau
pushed a commit
that referenced
this pull request
Jul 1, 2020
Refs: #28803 PR-URL: #32849 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #28803
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes